Skip to content

refactor: DF-380 - Add component dot getDisplayStringFromFormValue & …#180

Merged
whitewaterdesign merged 2 commits intomainfrom
refactor/DF-380--add-component-get-from-form-value
Aug 29, 2025
Merged

refactor: DF-380 - Add component dot getDisplayStringFromFormValue & …#180
whitewaterdesign merged 2 commits intomainfrom
refactor/DF-380--add-component-get-from-form-value

Conversation

@whitewaterdesign
Copy link
Copy Markdown
Contributor

@whitewaterdesign whitewaterdesign commented Aug 28, 2025

Proposed change

This is a refactor to add getContextValueFormFormValue and getDisplayStringFromFormValue methods to FormComponents, which will allow us to use the same logic for handling notify email formatting in separate service as in the plugin.

Jira ticket:

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
11.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@whitewaterdesign
Copy link
Copy Markdown
Contributor Author

Note, the SonarLint duplication issue is a long standing issue unrelated to the current PR

Copy link
Copy Markdown
Contributor

@davidjamesstone davidjamesstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whitewaterdesign whitewaterdesign merged commit 1e2e934 into main Aug 29, 2025
9 of 10 checks passed
@whitewaterdesign whitewaterdesign deleted the refactor/DF-380--add-component-get-from-form-value branch August 29, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants